Add notification sound toggle and per-log sound cues#43
Open
JairHan wants to merge 9 commits into
Open
Conversation
Add notification sound toggle and per-log sound cues
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds configurable notification sounds to the browser bridge logger, including a popup toggle and per-log-type sound patterns via an offscreen audio context.
Changes:
- Added a “Notification Sound” toggle to the popup UI and synced it via
chrome.storage.sync. - Extended status and message typing/status responses to carry
soundEnabled/logType. - Implemented log-type-specific tone patterns in the offscreen audio handler and wired logger → background → offscreen playback.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| bridge-browser/src/types.ts | Extends request/response types to support sound settings and log type. |
| bridge-browser/src/popup/index.ts | Adds popup checkbox UI and storage/message wiring for enabling log sounds. |
| bridge-browser/src/offscreen/audio.ts | Implements log-type-based sound patterns and playback scheduling. |
| bridge-browser/src/modules/logger.ts | Adds sound enablement state and triggers playback on log calls. |
| bridge-browser/src/content/main.ts | Applies sound enablement updates from messages/status to the logger. |
| bridge-browser/src/background/messages.ts | Adds handlers to persist sound setting and to trigger sound playback. |
| bridge-browser/src/background/attention_sound.ts | Passes optional logType through to the offscreen document. |
| bridge-browser/index.html | Adds the “Notification Sound” checkbox markup to the popup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.