Skip to content

Add notification sound toggle and per-log sound cues#43

Open
JairHan wants to merge 9 commits into
three-water666:mainfrom
JairHan:main
Open

Add notification sound toggle and per-log sound cues#43
JairHan wants to merge 9 commits into
three-water666:mainfrom
JairHan:main

Conversation

@JairHan

@JairHan JairHan commented May 31, 2026

Copy link
Copy Markdown

No description provided.

JairHan and others added 2 commits May 31, 2026 21:54
Copilot AI review requested due to automatic review settings May 31, 2026 14:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds configurable notification sounds to the browser bridge logger, including a popup toggle and per-log-type sound patterns via an offscreen audio context.

Changes:

  • Added a “Notification Sound” toggle to the popup UI and synced it via chrome.storage.sync.
  • Extended status and message typing/status responses to carry soundEnabled / logType.
  • Implemented log-type-specific tone patterns in the offscreen audio handler and wired logger → background → offscreen playback.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
bridge-browser/src/types.ts Extends request/response types to support sound settings and log type.
bridge-browser/src/popup/index.ts Adds popup checkbox UI and storage/message wiring for enabling log sounds.
bridge-browser/src/offscreen/audio.ts Implements log-type-based sound patterns and playback scheduling.
bridge-browser/src/modules/logger.ts Adds sound enablement state and triggers playback on log calls.
bridge-browser/src/content/main.ts Applies sound enablement updates from messages/status to the logger.
bridge-browser/src/background/messages.ts Adds handlers to persist sound setting and to trigger sound playback.
bridge-browser/src/background/attention_sound.ts Passes optional logType through to the offscreen document.
bridge-browser/index.html Adds the “Notification Sound” checkbox markup to the popup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bridge-browser/src/content/main.ts
Comment thread bridge-browser/src/popup/index.ts
Comment thread bridge-browser/src/types.ts
Comment thread bridge-browser/src/background/messages.ts
Comment thread bridge-browser/src/modules/logger.ts
Comment thread bridge-browser/src/offscreen/audio.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants