Bump Rust toolchain to 1.97 and fix new clippy lints - #437
Conversation
Unblocks serial_test 4.0.1 (requires rustc >= 1.93.1). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Greptile SummaryThe PR updates the pinned Rust toolchain from 1.91 to 1.97 and applies behavior-preserving changes required by the newer Clippy release.
Confidence Score: 5/5The PR appears safe to merge, with no concrete behavioral, build, or security regressions identified. The runtime edits are semantically equivalent lint fixes, the timeout values are unchanged, and the toolchain update has no identified conflict with repository build constraints. Important Files Changed
Reviews (1): Last reviewed commit: "Bump Rust toolchain to 1.97 and fix new ..." | Re-trigger Greptile |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
WalkthroughThe PR upgrades the Rust toolchain from 1.91 to 1.97. It simplifies parallelism fallback expressions and multiline test offset calculation. It expresses test timeouts with seconds-based constructors. It removes redundant trailing commas from two Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bumps the pinned toolchain in
rust-toolchain.tomlfrom 1.91 to 1.97 (current stable). This unblocks #431, as serial_test 4.0.1 requires rustc >= 1.93.1.Fixes the lints new to clippy 1.97:
map_unwrap_or:.map(NonZero::get).unwrap_or(4)->.map_or(4, NonZero::get)unnecessary_trailing_commainxtask/src/build_readme.rsduration_suboptimal_units:from_millis(2_000)->from_secs(2)etc. in testsexplicit_counter_loopin areplace.rstest helper, rewritten with.take()Verified locally with
cargo fmt --check,cargo clippy --workspace --tests -- -D warnings,cargo check,cargo xtask readme --checkandcargo test --workspace.