Fix errors that occur when you try to yarn watch:#1
Open
aimeehainesTJ wants to merge 1 commit into
Open
Conversation
aimeehainesTJ
commented
Jan 11, 2022
aimeehainesTJ
commented
- Modal.twig doesn't exist so needs removing
- SVG doesn't exist so needs removing
- Missing fluid-unit mixin
- Normalize import fails
- Missing file editor.js which is required
- Modal.twig doesn't exist so needs removing - SVG doesn't exist so needs removing - Missing fluid-unit mixin - Normalize import fails - Missing file editor.js which is required
harryfinn
requested changes
Jan 22, 2022
| @@ -0,0 +1,10 @@ | |||
| import { FontLoader } from './tools'; | |||
Contributor
There was a problem hiding this comment.
We probably don't want to load the theme fonts into the editor/CMS - perhaps we can add a placeholder or just console log for the editor file to be generated for now?
| document.documentElement.classList.add('fonts-loaded'); | ||
| } | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
Can you add a newline at the end of this file (keeps git happy) - Looks like you can enable this across all files in PHPStorm like so https://stackoverflow.com/a/36020003/2166894
| @@ -0,0 +1 @@ | |||
| export FontLoader from './fonts'; No newline at end of file | |||
| @@ -1 +1 @@ | |||
| @import 'normalize.css'; No newline at end of file | |||
| @import '~normalize.css'; No newline at end of file | |||
|
|
||
| @function fluid-unit($pixel_value) { | ||
| @return #{strip-unit($pixel_value) / strip-unit($max-font)}rem; | ||
| } No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.