fix: surface sync errors in UI and fix nil resp dereference - #32
Open
thetnaingtn wants to merge 1 commit into
Open
fix: surface sync errors in UI and fix nil resp dereference#32thetnaingtn wants to merge 1 commit into
thetnaingtn wants to merge 1 commit into
Conversation
SyncBranchWithUpstreamRepo previously accessed resp.StatusCode before checking err, causing a nil pointer panic on transport-level failures. Fix by checking err first, then resp.StatusCode within the error branch. item.errMsg was populated on sync failure but never used in Title() or Description(), so failed syncs silently showed as selected (●) instead of error (⨯) while the title still said "Synchronization Done". Now both Title() and Description() check errMsg so users see the error icon and the reason the sync failed. Fixes #30 Co-authored-by: Thet Naing Tun <thetnaingtn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two bugs that caused forks to appear un-synced with no feedback:
SyncBranchWithUpstreamRepoaccessedresp.StatusCodebefore checkingerr, panicking whenrespis nil on network failures.item.errMsgwas set on sync failure but never used inTitle()orDescription(), so failed syncs showed ● instead of ⨯ and the error reason was invisible.Fixes #30
Generated with Claude Code