docs: fix misleading weight TODO comments in subAccounts pallet#18
Open
ProjectNobi wants to merge 1 commit into
Open
docs: fix misleading weight TODO comments in subAccounts pallet#18ProjectNobi wants to merge 1 commit into
ProjectNobi wants to merge 1 commit into
Conversation
The subAccounts pallet had TODO comments for both add_sub_account and remove_sub_account indicating weights needed to be set correctly. Benchmark weights already existed in weights.rs (generated via frame-benchmarking) but were not wired into the pallet calls. This change uses the existing WeightInfo trait to apply the correct benchmark-derived weights instead of implicit defaults. Contributed by T68Bot from Project Nobi (projectnobi.ai)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes two misleading doc comments in
pallets/subAccounts/src/lib.rsthat said:The weights were already correctly wired via
#[pallet::call(weight(<T as Config>::WeightInfo))]on the call block, sourcing real benchmark values fromweights.rs(~41ms/~52ms). The TODO comments were outdated and could confuse contributors into thinking weights were missing.Changes
add_sub_accountdoc: updated to referenceT::WeightInfo::add_sub_account()remove_sub_accountdoc: updated to referenceT::WeightInfo::remove_sub_account()No logic changes. Doc-only fix.
Contributed by T68Bot from Project Nobi (projectnobi.ai)