Bugfix in simulator: unjustified "Genome length is less than shortest read length !"#38
Open
a-ludi wants to merge 3 commits into
Open
Bugfix in simulator: unjustified "Genome length is less than shortest read length !"#38a-ludi wants to merge 3 commits into
a-ludi wants to merge 3 commits into
Conversation
Owner
|
Thanks! Gene
…On 1/16/19, 12:16 PM, Arne wrote:
When trying to simulate reads from hg38 I got "Genome length is less
than shortest read length !" which of course is not true.
The issue was an signed integer overflow which is easily fixed using
the appropriate type |int64| in line 316.
------------------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#38
Commit Summary
* Bugfix in simulator
File Changes
* *M* simulator.c
<https://github.com/thegenemyers/DAZZ_DB/pull/38/files#diff-0> (8)
Patch Links:
* https://github.com/thegenemyers/DAZZ_DB/pull/38.patch
* https://github.com/thegenemyers/DAZZ_DB/pull/38.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGkkNl43gRJPOhOu0QPCU8Fx4vFySk5hks5vDwnwgaJpZM4aC113>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to simulate reads from hg38 I got "Genome length is less than shortest read length !" which of course is not true.
The issue was an signed integer overflow which is easily fixed using the appropriate type
int64in line 316.