Skip to content

Add logger as a dependency#932

Closed
bastelfreak wants to merge 1 commit into
theforeman:developfrom
bastelfreak:ruby4
Closed

Add logger as a dependency#932
bastelfreak wants to merge 1 commit into
theforeman:developfrom
bastelfreak:ruby4

Conversation

@bastelfreak

@bastelfreak bastelfreak commented Jan 23, 2026

Copy link
Copy Markdown
Member

This gem was vendored in Ruby until version 4.

$ git grep require.*logger
lib/proxy/log.rb:require 'logger'
lib/proxy/log.rb:      require 'syslog/logger'
test/log_buffer/decorator_test.rb:    require 'syslog/logger'

This gem was vendored in Ruby until version 4.

```
$ git grep require.*logger
lib/proxy/log.rb:require 'logger'
lib/proxy/log.rb:      require 'syslog/logger'
test/log_buffer/decorator_test.rb:    require 'syslog/logger'
```

@ekohl ekohl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to include it in #928 if this is needed (and I think you're right it is).

@bastelfreak

Copy link
Copy Markdown
Member Author

Feel free to pull it into your PR :)

@ekohl

ekohl commented Jan 23, 2026

Copy link
Copy Markdown
Member

Will do. And it's precisely the reason why testing all the dependencies is a good step :)

@ekohl ekohl closed this Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants