Manage more parameters - #115
Draft
ekohl wants to merge 1 commit into
Draft
Conversation
Merged
Member
|
Given we are on the verge of doing releases across all our modules, should this go in before hand? |
ekohl
force-pushed
the
manage-defaults-file
branch
from
January 27, 2022 18:40
0bd6fce to
0a65988
Compare
Member
Author
|
Rebased |
ekohl
marked this pull request as ready for review
January 27, 2022 18:41
This was referenced Jan 27, 2022
ekohl
force-pushed
the
manage-defaults-file
branch
2 times, most recently
from
January 27, 2022 18:52
850ad56 to
07518f5
Compare
Member
Author
|
This will be easier once #136 is merged. |
ekohl
force-pushed
the
manage-defaults-file
branch
from
October 27, 2022 15:33
07518f5 to
951f7a3
Compare
ekohl
force-pushed
the
manage-defaults-file
branch
from
October 27, 2022 15:36
951f7a3 to
4643a82
Compare
ekohl
marked this pull request as draft
October 27, 2022 15:36
Member
Author
|
I've rebased this to resolve the major conflicts, but I expect the tests to fail and this isn't ready. |
|
#141 extends this PR and fixes the issues |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This manages /etc/default/tftp-hpa on Debian since that defines the variables. This allows parameters to actually change them and have effect. For the same reason, on EL a drop in is used to respect the root.
Currently still a bit messy. Also needs more tests.
Replaces #91 (Debian part) and #113 (EL part).