fix(FDW): update inventory view to match current HBI schema#104
Merged
ehelms merged 1 commit intoJul 8, 2026
Merged
Conversation
The inventory.hosts view references three HBI columns that have been dropped in production. Without this change, the view creation fails with "column does not exist" errors, breaking FDW imports. - canonical_facts: insights_id read directly as UUID column [1] - system_profile_facts: LEFT JOIN to system_profiles_static for operating_system, host_type, owner_id [2] - stale_timestamp: computed from last_check_in using HBI defaults: 29h/7d/30d [3]. Fixes pre-existing bug where stale_warning and culled were chained off stale_timestamp instead of computed independently from last_check_in. WHERE clause updated: canonical_facts->'insights_id' IS NOT NULL replaced with insights_id != '00000000-...' (DEFAULT_INSIGHTS_ID sentinel). Staleness intervals are hardcoded HBI defaults. Per-org overrides from hbi.staleness table are not reflected in this view. [1] RedHatInsights/insights-host-inventory@7754a5a [2] RedHatInsights/insights-host-inventory@62f4d24 [3] RedHatInsights/insights-host-inventory@426d5e0 Signed-off-by: Roman Blanco <rblanco@redhat.com>
Member
|
I assume https://github.com/theforeman/foremanctl/blob/master/src/roles/iop_inventory/tasks/main.yaml#L224 will need the same treatment? |
Contributor
Author
|
ehelms
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inventory.hosts view references three HBI columns that have been dropped in production. Without this change, the view creation fails with
"column does not exist"errors, breaking FDW imports.canonical_facts: insights_id read directly as UUID column [1]system_profile_facts: LEFT JOIN tosystem_profiles_staticforoperating_system,host_type,owner_id[2]stale_timestamp: computed fromlast_check_inusing HBI defaults: 29h/7d/30d [3]. Fixes pre-existing bug where stale_warning and culled were chained off stale_timestamp instead of computed independently fromlast_check_in.WHERE clause updated:
canonical_facts->'insights_id' IS NOT NULLreplaced withinsights_id != '00000000-...'(DEFAULT_INSIGHTS_IDsentinel).Staleness intervals are hardcoded HBI defaults. Per-org overrides from
hbi.stalenesstable are not reflected in this view.[1] RedHatInsights/insights-host-inventory@7754a5a
[2] RedHatInsights/insights-host-inventory@62f4d24
[3] RedHatInsights/insights-host-inventory@426d5e0