enable toggle for update-static-leases param for ddns enabled config#248
Open
ikonia wants to merge 4 commits into
Open
enable toggle for update-static-leases param for ddns enabled config#248ikonia wants to merge 4 commits into
ikonia wants to merge 4 commits into
Conversation
evgeni
reviewed
Jun 18, 2026
evgeni
reviewed
Jun 18, 2026
evgeni
requested changes
Jun 28, 2026
evgeni
left a comment
evgeni
left a comment
Member
There was a problem hiding this comment.
ack once docs are at their place :)
pr-processor
Bot
added
Needs re-review
and removed
Waiting on contributor
Needs re-review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forman-installer options support enabling ddns within dhcpd configuration when ddns is enabled via this module the parameter update-static-leases is hardcoded to on.
In a foreman environment where provisioning is mixed with non-provisioned host this causes a failure in Foreman provisioning as the DNS record for host.domain.com is removed and replaced with host.domain.com.domain.com which is both incorrect and a failure to the foreman build process as the node is defined in puppet as host.domain.com
This functionality is useful outside of foreman for dhcp environments,
while dhcp is deprecated to be replaced with kea, this is a minor update that I believe adds value