Fixes #39414 - Show unrecognized smart proxy features in list and info#656
Conversation
|
Just a nit: Features:
1) Name: Dynflow
2) Name: Script
3) Name: Logs
Unrecognized features: openscapCan we unify the output? I mean either it's just a comma-separated list or "numerized lines", having both feels weird. |
Display unrecognized_features from the Foreman API response in both the list and info commands, hidden when blank. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ac1725f to
aa67933
Compare
|
Unified |
|
And now even without listing the unrecognized features twice |
There was a problem hiding this comment.
Thanks, @adamruzicka !
Works as expected:
$ hm proxy list
---|----------------------|-----------------------------------|--------------|----------------------
ID | NAME | URL | FEATURES | UNRECOGNIZED FEATURES
---|----------------------|-----------------------------------|--------------|----------------------
1 | foreman.ofedoren.com | https://foreman.ofedoren.com:9090 | Dynflow, ... | myfeature
---|----------------------|-----------------------------------|--------------|----------------------$ hm proxy info --id 1
Id: 1
Name: foreman.ofedoren.com
URL: https://foreman.ofedoren.com:9090
Host count: 8
Features:
1) Name: Dynflow
# ...
Unrecognized features:
1) Name: myfeature
Locations:
Default Location
Organizations:
Default Organization
Created at: 2024/08/20 10:37:13
Updated at: 2026/06/22 14:41:54$ hm --output yaml proxy list
---
- Id: 1
Name: foreman.ofedoren.com
URL: https://foreman.ofedoren.com:9090
Features:
- Dynflow
# ...
Unrecognized features:
- myfeatureRegarding missing tests: well, it would be nice to have them, but I don't see any decent existing test anyway, it would require us to cover everything instead of just unrecognized feature thingy, so it's up to you.
Also, it's worth to mention that we have now a new string to extract, so we could do it here or hope that maintainers still do that :)
P.S. I've noticed that we have really outdated test/data, so I'll probably open a maintenance PR, maybe include the i18n extraction there.
Companion to theforeman/foreman#11017
Display unrecognized_features from the Foreman API response in both the list and info commands, hidden when blank.
To be squashed on merge