Use postgresql_upgrade role from foreman-operations-collection for Fo…

[ehelms]

…reman upgrades

PLAY RECAP *******************************************************************************************************************************************************************************************************************************************************************************
localhost                  : ok=5    changed=2    unreachable=0    failed=0    skipped=2    rescued=0    ignored=0   
pipe-up-foreman-nightly-centos8 : ok=134  changed=37   unreachable=0    failed=0    skipped=87   rescued=0    ignored=2   
pipe-up-foreman-smoker-nightly-centos8 : ok=18   changed=13   unreachable=0    failed=0    skipped=2    rescued=0    ignored=0   

ehelms@wareagle forklift (use-puppet-upgrade-foc)$ vagrant ssh pipe-up-foreman-nightly-centos8
sudo su
rpm -q postgresql*******************************************************************************
This is a private virtual machine that is the property of the Foreman project.
It is for authorized use only. Users (authorized or unauthorized) have no
explicit or implicit expectation of privacy.

Any or all uses of this system and all files on this system may be monitored,
recorded, copied, audited, or inspected.

LOG OFF IMMEDIATELY if you do not agree to the conditions stated in this
warning.
*******************************************************************************

CentOS 8.3.2011 x86_64

FQDN:      pipe-up-foreman-nightly-centos8.wareagle.example.com (192.168.122.235)
Processor: 2x Intel Core Processor (Skylake, IBRS)
Kernel:    4.18.0-240.1.1.el8_3.x86_64
Memory:    4.40 GiB


Last login: Mon Mar  8 18:43:52 2021 from 192.168.122.1
sudo su
rpm -q postgresql-[vagrant@pipe-up-foreman-nightly-centos8 ~]$ sudo su
s[root@pipe-up-foreman-nightly-centos8 vagrant]# rpm -q postgresql-server
postgresql-server-12.5-1.module_el8.3.0+620+f1abd701.x86_64

[ekohl]

Also needs to upgrade instructions. Also update CI. I still really dislike adding a dependency on Ansible collections.

[ehelms]

Here I have broken out to make the Pulp piece stand-alone: #1314

[ehelms]

Job update -- theforeman/jenkins-jobs#18

[evgeni]

Left a few blocking comments, but overall this is the direction we should be aiming.

I do wonder if the installation should default to True tho, as it's something we will need in our CI all the time (minus the pulpcore pipes, which can set it to False)?

[ehelms]

I do wonder if the installation should default to True tho, as it's something we will need in our CI all the time (minus the pulpcore pipes, which can set it to False)?

Works for me to make it straight forward for the main use case. I updated the jenkins job PR as well.

[evgeni]

ACK

@ekohl any objections besides "it uses/requires collections"?

[ehelms]

@ekohl Is this what you were looking for?

[ehelms]

@ekohl Looking for your final input here

[ekohl]

@ekohl any objections besides "it uses/requires collections"?

No, that's still my main issue. IMHO we should still strive to use less Ansible, not more. The risk I see is that we're building a foreman-maintain 2.0. However, I'm willing to step aside and let you deal with it.

[ehelms]

No, that's still my main issue. IMHO we should still strive to use less Ansible, not more. The risk I see is that we're building a foreman-maintain 2.0. However, I'm willing to step aside and let you deal with it.

What I always find I am missing with these sort of comments is what the alternative is. If you are proposing we move away from Ansible, where should we head?

[ekohl]

I am wondering if the Foreman installer should take care of it. Personally I think we should also introduce an installer scenario that sets up just the PostgreSQL server for external DB access. Then you could reuse the code there.

[evgeni]

I think we discussed this (let installer do the pg10→12 upgrade) and ended up saying that this is a corner case (only needed upstream, only on el8, and at that time only Foreman) which we handle via docs/ansible.

Looking at theforeman/foreman-installer#650, we wanted to pick it back to 2.4 -- to make Katello start out with 12 on el8, but never did.