Move flavor default into playbook vars#623
Open
ehelms wants to merge 1 commit into
Open
Conversation
Set the flavor variable directly in each playbook rather than relying on a global default in defaults.yml. This makes each playbook explicit about its flavor and prepares for per-host state partitioning where different hosts use different flavors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
The
flavorvariable was defined as a global default (katello) indefaults.yml. This works when all playbooks target quadlet, but breaks with per-host state partitioning wheredeploy-proxyuses a different flavor (foreman-proxy-content). Having a single global default obscures which flavor each playbook actually requires and makes it easy for new playbooks to silently depend on a default that may not apply.What are the changes introduced in this pull request?
flavor: katellofromsrc/vars/defaults.ymlflavorexplicitly in thevars:block of every playbook that loadsflavors/{{ flavor }}.yml:deploy.yaml—katellodeploy-proxy.yaml—foreman-proxy-contentchecks.yaml,health.yaml,backup.yaml,pull-images.yaml,features.yaml—katellodeploy-dev.yaml,remote-database.yaml—katelloHow to test this pull request
Steps to reproduce:
./foremanctl deploy --initial-admin-password=changeme --tuning developmentand verify deployment succeeds./foremanctl checks,./foremanctl health,./foremanctl featuresand verify no undefined variable errors./forge deploy-devand verify no undefined variable errorsChecklist