Skip to content

Drop checks role from setup-foreman-proxy#326

Merged
stejskalleos merged 1 commit into
theforeman:masterfrom
ehelms:remove-checks-proxy
Nov 27, 2025
Merged

Drop checks role from setup-foreman-proxy#326
stejskalleos merged 1 commit into
theforeman:masterfrom
ehelms:remove-checks-proxy

Conversation

@ehelms

@ehelms ehelms commented Nov 25, 2025

Copy link
Copy Markdown
Member

In their current form, the checks only apply to the Foreman itself.

@ehelms

ehelms commented Nov 26, 2025

Copy link
Copy Markdown
Member Author

@stejskalleos, @evgeni what do you think?

@stejskalleos stejskalleos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stejskalleos stejskalleos merged commit 27daea9 into theforeman:master Nov 27, 2025
8 checks passed
@evgeni

evgeni commented Dec 2, 2025

Copy link
Copy Markdown
Member

@ehelms which checks did you not want to run on a proxy? check_system_requirements?

I am asking because #188 adds it back, effectively, so I want to follow up with a feature-based disablement.

@ehelms

ehelms commented Dec 2, 2025

Copy link
Copy Markdown
Member Author

@ehelms which checks did you not want to run on a proxy? check_system_requirements?

I am asking because #188 adds it back, effectively, so I want to follow up with a feature-based disablement.

The database check, and system requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants