Skip to content

feat(Compliance): onboarding compliance frontend#1221

Open
LightOfHeaven1994 wants to merge 2 commits into
theforeman:developfrom
LightOfHeaven1994:onboard-compliance-frontend
Open

feat(Compliance): onboarding compliance frontend#1221
LightOfHeaven1994 wants to merge 2 commits into
theforeman:developfrom
LightOfHeaven1994:onboard-compliance-frontend

Conversation

@LightOfHeaven1994

@LightOfHeaven1994 LightOfHeaven1994 commented Jun 22, 2026

Copy link
Copy Markdown

What are the changes introduced in this pull request?

Initial compliance-frontend onboarding by adding routes, placeholder page and permissions required.
inspired by the way how other apps have been onboarded step by step #999.

I also have this PR but it adds some tweaks that I'm not sure about yet (since we are still looking into the best way to integrate compliance into IoP)

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Run foreman with foreman_rh_cloud, navigate to Insights, open nav menu and see that Compliance Reports and SCAP Policies entries are in place. If you select one of these - you will see This page is under development. Please check back soon for updates.

Screenshot 2026-06-22 at 16 37 42

@LightOfHeaven1994 LightOfHeaven1994 force-pushed the onboard-compliance-frontend branch from f5f5055 to 5b51cde Compare June 22, 2026 14:38

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider making the placeholder text in InsightsCompliancePlaceholder translatable using the same i18n mechanism used elsewhere in the React frontend, so it can be localized like other UI strings.
  • The naming for SCAP policies is a bit inconsistent (scappolicies in paths and route names); aligning this to a clearer, consistently formatted name (e.g., scap_policies or scapPolicies) across routes, menu keys, and component names would improve readability and maintainability.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider making the placeholder text in `InsightsCompliancePlaceholder` translatable using the same i18n mechanism used elsewhere in the React frontend, so it can be localized like other UI strings.
- The naming for SCAP policies is a bit inconsistent (`scappolicies` in paths and route names); aligning this to a clearer, consistently formatted name (e.g., `scap_policies` or `scapPolicies`) across routes, menu keys, and component names would improve readability and maintainability.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LightOfHeaven1994

Copy link
Copy Markdown
Author

@vkrizan @nofaralfasi I believe it should be enough for showing some basics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant