feat(Compliance): onboarding compliance frontend#1221
Open
LightOfHeaven1994 wants to merge 2 commits into
Open
feat(Compliance): onboarding compliance frontend#1221LightOfHeaven1994 wants to merge 2 commits into
LightOfHeaven1994 wants to merge 2 commits into
Conversation
f5f5055 to
5b51cde
Compare
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider making the placeholder text in
InsightsCompliancePlaceholdertranslatable using the same i18n mechanism used elsewhere in the React frontend, so it can be localized like other UI strings. - The naming for SCAP policies is a bit inconsistent (
scappoliciesin paths and route names); aligning this to a clearer, consistently formatted name (e.g.,scap_policiesorscapPolicies) across routes, menu keys, and component names would improve readability and maintainability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider making the placeholder text in `InsightsCompliancePlaceholder` translatable using the same i18n mechanism used elsewhere in the React frontend, so it can be localized like other UI strings.
- The naming for SCAP policies is a bit inconsistent (`scappolicies` in paths and route names); aligning this to a clearer, consistently formatted name (e.g., `scap_policies` or `scapPolicies`) across routes, menu keys, and component names would improve readability and maintainability.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Author
|
@vkrizan @nofaralfasi I believe it should be enough for showing some basics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Initial compliance-frontend onboarding by adding routes, placeholder page and permissions required.
inspired by the way how other apps have been onboarded step by step #999.
I also have this PR but it adds some tweaks that I'm not sure about yet (since we are still looking into the best way to integrate compliance into IoP)
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Run foreman with foreman_rh_cloud, navigate to Insights, open nav menu and see that
Compliance ReportsandSCAP Policiesentries are in place. If you select one of these - you will seeThis page is under development. Please check back soon for updates.