Skip to content

add padding for Vulnerabilities host details tab - #1041

Merged
jeremylenz merged 1 commit into
theforeman:developfrom
jeremylenz:vuln-padding
Jul 29, 2025
Merged

add padding for Vulnerabilities host details tab#1041
jeremylenz merged 1 commit into
theforeman:developfrom
jeremylenz:vuln-padding

Conversation

@jeremylenz

@jeremylenz jeremylenz commented Jul 24, 2025

Copy link
Copy Markdown
Collaborator

What are the changes introduced in this pull request?

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Summary by Sourcery

Add consistent padding to the Vulnerabilities host details tab by introducing a new SCSS file and importing it into the component.

Enhancements:

  • Introduce CVEsHostDetailsTab.scss to apply 24px padding to the host details component
  • Import the new SCSS file into CVEsHostDetailsTab.js to activate the styling

@sourcery-ai

sourcery-ai Bot commented Jul 24, 2025

Copy link
Copy Markdown

Reviewer's Guide

This PR enhances the CVEs host details tab by importing a new SCSS file and applying a 24px padding rule to its root container.

File-Level Changes

Change Details Files
Added 24px padding styling to the host details component
  • Imported the new SCSS file into the component
  • Created the SCSS file defining the 24px padding rule
webpack/CVEsHostDetailsTab/CVEsHostDetailsTab.js
webpack/CVEsHostDetailsTab/CVEsHostDetailsTab.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@jeremylenz
jeremylenz marked this pull request as ready for review July 24, 2025 17:13

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jeremylenz - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@chris1984 chris1984 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, is there a box I can test it on?

@jeremylenz

Copy link
Copy Markdown
Collaborator Author

is there a box I can test it on?

@vkrizan can help with that

@jeremylenz

Copy link
Copy Markdown
Collaborator Author

Actually I think you can just look at the host details Vulnerabilities tab (with IoP on) and make sure the Scalprum placeholder is padded.

@chris1984

Copy link
Copy Markdown
Member

Actually I think you can just look at the host details Vulnerabilities tab (with IoP on) and make sure the Scalprum placeholder is padded.

I don't have IOP on my devel box, I just have been using the test system. Can I test it on that one or are people still doing things with it?

@jeremylenz

Copy link
Copy Markdown
Collaborator Author

Aleksandr is testing with that one

@Gauravtalreja1

Copy link
Copy Markdown
Contributor

I think this might address @vkrizan 's earlier comment, and here’s how it looks now. Could you please confirm if this aligns with what was expected?
Screenshot 2025-07-27 at 5 02 49 AM

@ShimShtein

Copy link
Copy Markdown
Member

@MariSvirik Can you please take a look at the last screenshot?

@chris1984 chris1984 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MariSvirik

Copy link
Copy Markdown

Yep, padding looks as expected.

But the tabs aren't ok according to PF5. The blue underline (of the selected tab) should be integrated with a horizontal grey line beneath all the tabs. See PF5 guidelines. But that's the Satellite issue not Vulnerabilities.
Screenshot 2025-07-29 at 12 06 16

@jeremylenz
jeremylenz merged commit 49976a1 into theforeman:develop Jul 29, 2025
23 checks passed
@jeremylenz

Copy link
Copy Markdown
Collaborator Author

But the tabs aren't ok according to PF5. The blue underline (of the selected tab) should be integrated with a horizontal grey line beneath all the tabs. See PF5 guidelines.

Opened https://projects.theforeman.org/issues/38623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants