add padding for Vulnerabilities host details tab - #1041
Conversation
Reviewer's GuideThis PR enhances the CVEs host details tab by importing a new SCSS file and applying a 24px padding rule to its root container. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @jeremylenz - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
chris1984
left a comment
There was a problem hiding this comment.
Code looks good to me, is there a box I can test it on?
@vkrizan can help with that |
|
Actually I think you can just look at the host details Vulnerabilities tab (with IoP on) and make sure the Scalprum placeholder is padded. |
I don't have IOP on my devel box, I just have been using the test system. Can I test it on that one or are people still doing things with it? |
|
Aleksandr is testing with that one |
|
@MariSvirik Can you please take a look at the last screenshot? |
|
Yep, padding looks as expected. But the tabs aren't ok according to PF5. The blue underline (of the selected tab) should be integrated with a horizontal grey line beneath all the tabs. See PF5 guidelines. But that's the Satellite issue not Vulnerabilities. |
|


What are the changes introduced in this pull request?
Considerations taken when implementing this change?
What are the testing steps for this pull request?
Summary by Sourcery
Add consistent padding to the Vulnerabilities host details tab by introducing a new SCSS file and importing it into the component.
Enhancements: