Integrate SystemDetailTable component into Host Details CVEs tab - #1025
Integrate SystemDetailTable component into Host Details CVEs tab#1025nofaralfasi wants to merge 9 commits into
Conversation
Requests that are generated by a host, as opposed to a user will receive a forwarded header with host uuid.
… host (theforeman#1011) * Enable hosts filter in report * Observe package upload actions in Katello * Switch to foreman cert when in IoP mode * Make rubocop happy * Fix filtering errors
Reviewer's GuideThis PR integrates a new CVE tab into the UI via Scalprum modules, significantly refactors inventory upload by adding robust hostname and IP obfuscation controlled by global and per-host settings with JSON resilience, introduces a hosts_filter parameter throughout the report-generation pipeline, enhances cloud telemetry forwarding by including host context and dynamic certificate selection, and aligns supporting tests, versioning, and documentation accordingly. Sequence diagram for cloud telemetry request forwarding with host context and dynamic certificate selectionsequenceDiagram
participant Controller as MachineTelemetriesController
participant Forwarder as CloudRequestForwarder
participant CertAuth as CertAuth
participant Cloud as Cloud API
Controller->>Forwarder: forward_request(request, controller_name, branch_id, certs, host)
Forwarder->>Forwarder: prepare_forward_params()
Forwarder->>Forwarder: prepare_request_opts(..., certs, host)
Forwarder->>Forwarder: prepare_forwarded_header(host)
Forwarder->>Cloud: execute_cloud_request(request_opts)
Note over Forwarder,Cloud: request includes Forwarded header and correct certs
Cloud-->>Forwarder: response
Forwarder-->>Controller: response
Class diagram for obfuscation logic and report generation changesclassDiagram
class FactHelpers {
+obfuscate_hostname?(host)
+fqdn(host)
+obfuscate_ips?(host)
+host_ips(host)
+obfuscated_ips(host)
+obfuscate_ip(ip, ips_dict)
}
class ArchivedReport {
+render(organization, filter)
}
class Queries {
+for_org(organization_id, use_batches, hosts_query)
}
class GenerateReportJob {
+plan(base_folder, organization_id, disconnected, hosts_filter)
+hosts_filter
}
FactHelpers <|-- ArchivedReport
ArchivedReport <|-- Queries
Queries <|-- GenerateReportJob
Class diagram for Scalprum context and CVE tab componentsclassDiagram
class ScalprumContextWrapper {
+config
+mockUser
+children
}
class CVEsHostDetailsTab {
+ScalprumComponent
+PageLayout
}
class CVEsHostDetailsTabWrapper {
+ScalprumContextWrapper
+CVEsHostDetailsTab
}
ScalprumContextWrapper <|-- CVEsHostDetailsTabWrapper
CVEsHostDetailsTabWrapper *-- CVEsHostDetailsTab
Class diagram for InsightsCloud::PackageProfileUploadExtensions concernclassDiagram
class PackageProfileUploadExtensions {
+generate_host_report()
}
class CandlepinDynflowProxyController
CandlepinDynflowProxyController <|.. PackageProfileUploadExtensions
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
eb47aa5 to
26890c1
Compare
| const module = './SystemDetailTable'; | ||
| return ( | ||
| <div className="rh-cloud-insights-vulnerability-page"> | ||
| <ScalprumComponent scope={scope} module={module} /> |
There was a problem hiding this comment.
Yes, I need to add it.
| @@ -31,7 +32,7 @@ const fills = [ | |||
| { | |||
| slot: 'host-details-page-tabs', | |||
| name: 'CVEs', | |||
There was a problem hiding this comment.
Tab name should be "Vulnerabilities"
| component: props => <CVEsHostDetailsTabWrapper {...props} />, | ||
| weight: 300, | ||
| metadata: { | ||
| hideTab: vulnerabilityDisabled, |
There was a problem hiding this comment.
What are the conditions for hiding the Vulnerabilities tab?
There was a problem hiding this comment.
There was a problem hiding this comment.
I've got some issues with it when it got hidden, eventough I had the feature enabled. Could it be an issue with the RHEL check?
There was a problem hiding this comment.
Not sure, it's working fine for me. Maybe try debugging and see what's going on?
|
Closing this PR in favor of #1031, where the work will continue. |
Tests still need to be fixed.
Summary by Sourcery
Add new CVEs tab and host-filtering capabilities, enhance obfuscation and cloud forwarding logic, inject package profile upload hooks, and bump version and dependencies
New Features:
Enhancements:
Build:
Documentation:
Tests: