Show the view state of puppet modules/classes using chevrons on puppetclass selection page#439
Show the view state of puppet modules/classes using chevrons on puppetclass selection page#439me-minus wants to merge 3 commits into
Conversation
|
Hi @me-minus ! Thanks for the contribution! Do you mind providing a screenshot that show cases your change? |
|
|
Looks good to me and works fine. But I don't want to merge this without the consent of @adamruzicka . |
adamruzicka
left a comment
adamruzicka
left a comment
There was a problem hiding this comment.
The erb is mixing tabs and spaces for indentation. Could you please only use spaces for that?
| </ul> | ||
|
|
||
| <div class="panel-group paneless puppetclass_group" id="<%= list.first %>-avail-classes" style="margin-bottom: 1px;"> | ||
| <div class="panel-heading" style="padding-top: 2px; padding-bottom: 2px;"> |
There was a problem hiding this comment.
I can't say I'm exactly happy about inline styling all over the place. Could that be extracted to classes?
There was a problem hiding this comment.
I could not find a way to extract the styling, so I removed it but then the spacing gets wonky
Do you have any hints on where I could look?
| .show(); | ||
| .show() | ||
| .filter('div') | ||
| .find('a.collapsed') |
There was a problem hiding this comment.
Where is the collapsed class being set on a <a>?
There was a problem hiding this comment.
I don't really know.
I used the developers pane to find out how the attributes changed with some hints from the _classes.html.erb file.
The code was created by changing/playing with the left menu pane code in an older foreman version (probably before parternfly 5)
pr-processor
Bot
added
Needs re-review
and removed
Waiting on contributor
Needs re-review
labels
…puppet class selection view
3 participants
This commit changes the add puppet class view to be a bit more like a tree by changing the big + to be a right chevron or down chevron if the module has been opened.
When I have shown people how to create machines with the help of foreman, many have wondered what the difference between the '+' symbols when adding puppet classes are.
Original (from foreman 3.19.0 + foreman_puppet 10.1.1):
Changed version:
