Skip to content

[WIP] - add custom notification for scan jobs#326

Open
ares wants to merge 1 commit into
theforeman:masterfrom
ares:fix/notification_customizations
Open

[WIP] - add custom notification for scan jobs#326
ares wants to merge 1 commit into
theforeman:masterfrom
ares:fix/notification_customizations

Conversation

@ares

@ares ares commented Feb 16, 2018

Copy link
Copy Markdown
Member

No description provided.

:links => [{
:path_method => :job_invocation_path,
:title => _('Job Details')
}]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the right brace the same as the start of the line where the left brace is.

subject,
{
:links => [{
:path_method => :job_invocation_path,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

:links => [{
:path_method => :host_path,
:title => _('Scanned Host')
}]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the right brace the same as the start of the line where the left brace is.

subject.template_invocations_hosts.first,
{
:links => [{
:path_method => :host_path,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

:links => [{
:path_method => :job_invocation_path,
:title => _('Job Details')
}]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the right brace the same as the start of the line where the left brace is.

subject,
{
:links => [{
:path_method => :job_invocation_path,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

:links => [{
:path_method => :host_path,
:title => _('Scanned Host')
}]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the right brace the same as the start of the line where the left brace is.

subject.template_invocations_hosts.first,
{
:links => [{
:path_method => :host_path,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.

@adamruzicka

Copy link
Copy Markdown
Contributor

@ares do we still want this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants