Fix Ruby 3.3 constant lookup for HostStatus - #69
Open
zjhuntin wants to merge 1 commit into
Open
Conversation
On Ruby 3.3, constant lookup inside instance_eval blocks no longer falls through to top-level scope. Qualify HostStatus with :: to ensure it resolves correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HostStatuswith::prefix in engine.rb plugin registration blockOn Ruby 3.3 (shipped with EL10), constant lookup inside
instance_evalblocks no longer falls through to top-level scope. The unqualifiedHostStatus::OmahaStatusreference on line 31 causes:This breaks the
plugin:assets:precompilerake task during RPM build, preventing the package from building on EL10.Other Foreman plugins (e.g.
foreman_openscap) already use fully qualified constants likeForemanOpenscap::ComplianceStatusin the same context and work correctly.