Run rpm-datarepair on upgrade Pulp RPM 4073#1088
Merged
Merged
Conversation
(cherry picked from commit 9dbe24e)
Member
|
if you pick 416a170 the tests will pass |
Member
|
my original comment had the wrong commit, you need 416a170 |
- 6.x splits out Minitest::Mock into an own gem: minitest-mock - 6.x requires Ruby 3.2 - minitest-mock requires Ruby 3.1 As we need to keep Ruby 3.0 compatibility, we can't depend on minitest-mock unconditionally. Let's keep us on minitest 5.x for now (cherry picked from commit 416a170)
evgeni
approved these changes
May 20, 2026
evgeni
left a comment
evgeni
left a comment
Member
There was a problem hiding this comment.
ACK on the diff, but I did not verify that the Pulp in the targeted release supports rpm-datarepair 4073 already
Contributor
Author
|
The pulp version in the targeted releases do support rpm-datarepair 4073. |
Member
|
Thanks, released as 1.10.5: https://github.com/theforeman/foreman_maintain/actions/runs/26738881725 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 9dbe24e)