Skip to content

self-upgrade next target_version#1083

Merged
stejskalleos merged 1 commit into
masterfrom
ls/SAT-33478
Apr 27, 2026
Merged

self-upgrade next target_version#1083
stejskalleos merged 1 commit into
masterfrom
ls/SAT-33478

Conversation

@stejskalleos

@stejskalleos stejskalleos commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

For the self-upgrade scenario:

  • set the target version to X.Y+1
  • disable the repository after the upgrade

evgeni
evgeni reviewed Apr 10, 2026
View reviewed changes
Comment thread definitions/scenarios/self_upgrade.rb Outdated
@stejskalleos

stejskalleos commented Apr 15, 2026

Copy link
Copy Markdown
Contributor Author

@evgeni, ready for review, fixed the bump version & updated tests.

evgeni
evgeni reviewed Apr 15, 2026
View reviewed changes
Comment thread definitions/scenarios/self_upgrade.rb Outdated
evgeni
evgeni reviewed Apr 15, 2026
View reviewed changes
Comment thread definitions/procedures/repositories/disable.rb
evgeni
evgeni reviewed Apr 15, 2026
View reviewed changes
Comment thread test/definitions/scenarios/self_upgrade_test.rb Outdated
evgeni
evgeni reviewed Apr 15, 2026
View reviewed changes
Comment thread test/definitions/scenarios/self_upgrade_test.rb
@stejskalleos

stejskalleos commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

I'm not able to make the tests work, so pushing without green runs.
@evgeni, is this the approach we should take to fix it?
I don't handle the 6.y -> 7.0 update, do I need to care about it?

@stejskalleos stejskalleos force-pushed the ls/SAT-33478 branch 2 times, most recently from 777cb07 to 1a7494b Compare April 16, 2026 08:16
evgeni
evgeni reviewed Apr 16, 2026
View reviewed changes
Comment thread test/definitions/scenarios/self_upgrade_test.rb Outdated
evgeni
evgeni reviewed Apr 16, 2026
View reviewed changes
Comment thread definitions/scenarios/self_upgrade.rb
@stejskalleos stejskalleos changed the title Enable maintainance repo in self-upgrade self-upgrade next target_version Apr 20, 2026
@stejskalleos

stejskalleos commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

@evgeni update, added tests & disabling the repos.

stejskalleos
stejskalleos commented Apr 20, 2026
View reviewed changes
Comment thread definitions/scenarios/self_upgrade.rb Outdated
evgeni
evgeni reviewed Apr 20, 2026
View reviewed changes
Comment thread test/definitions/scenarios/self_upgrade_test.rb Outdated
evgeni
evgeni reviewed Apr 22, 2026
View reviewed changes
Comment thread test/definitions/scenarios/self_upgrade_test.rb Outdated
@stejskalleos

stejskalleos commented Apr 22, 2026

Copy link
Copy Markdown
Contributor Author

@evgeni self_test updated

evgeni
evgeni reviewed Apr 22, 2026
View reviewed changes
Comment thread test/definitions/scenarios/self_upgrade_test.rb Outdated
evgeni
evgeni reviewed Apr 22, 2026
View reviewed changes
Comment thread test/definitions/scenarios/self_upgrade_test.rb Outdated
evgeni
evgeni reviewed Apr 23, 2026
View reviewed changes

@evgeni evgeni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall 👍

Comment thread definitions/scenarios/self_upgrade.rb Outdated
Comment thread test/definitions/scenarios/self_upgrade_test.rb
Comment thread test/definitions/scenarios/self_upgrade_test.rb Outdated
Comment thread definitions/scenarios/self_upgrade.rb
@stejskalleos

stejskalleos commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

@evgeni
I applied the changes and updated the tests. If you ack it, I'd like to rebase the PR into a single commit before merge.

@evgeni

evgeni commented Apr 24, 2026

Copy link
Copy Markdown
Member

@stejskalleos you decided not to update the error text?

otherwise the diff looks fine to me. will do a few more tests, but shouldn't prevent you from squashing.

@stejskalleos
self-upgrade next target_version
246fe19 
For the self-upgrade scenario:
* set the target version to X.Y+1
* disable the repository after the upgrade
@stejskalleos

stejskalleos commented Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

@stejskalleos you decided not to update the error text?

I did, but then probably accidentally reverted it when editing other code. Fixed again.

evgeni
evgeni approved these changes Apr 24, 2026
View reviewed changes

@evgeni evgeni left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on 6.16, 6.17 and 6.18 boxes.

6.16 → raises an error, as expected.
6.17 (with f-m built for 6.18) → tries to upgrade via 6.18 repos
6.18 (with f-m built for 6.18) → tries to upgrade via 6.19 repos

Also tested --maintenance-repo-label -- that still works and is unaffected by the changes here.

@stejskalleos stejskalleos merged commit 51a3de1 into master Apr 27, 2026
8 checks passed
@stejskalleos stejskalleos deleted the ls/SAT-33478 branch April 27, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evgeni evgeni evgeni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stejskalleos @evgeni