Fixes #39427 - Drop warn: false from Module Action - Ansible Default template#795
Open
adamruzicka wants to merge 1 commit into
Open
Fixes #39427 - Drop warn: false from Module Action - Ansible Default template#795adamruzicka wants to merge 1 commit into
adamruzicka wants to merge 1 commit into
Conversation
…template Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Module Action - Ansible Default" job template passes
warn: falseto Ansible'sshellmodule. Thewarnparameter was deprecated in ansible-core 2.12 and fully removed in ansible-core 2.14, where its presence causes a fatal error:This breaks all Ansible module actions for users on Ansible 2.14+.
Fix
Remove the
args: warn: falseblock from the template. Thewarn: falsewas originally used to suppress Ansible's suggestion to use thednfmodule instead of invokingdnfviashell. Since the warning mechanism itself was removed in 2.14, the parameter can simply be dropped:warnwas never a concern; the shell module worked fine without it.warnwas deprecated but still accepted — omitting it means users may see the suggestion to use thednfmodule directly, but it is harmless.warnis fully removed; omitting it is the correct behavior.Related
Reported in https://community.theforeman.org/t/ansible-error-on-both-foreman-3-17-and-3-18/46806