Fixes #39425 - Update RoleSwitcherError from pf3 to pf5#793
Merged
Conversation
kmalyjur
requested changes
Jun 16, 2026
kmalyjur
left a comment
kmalyjur
left a comment
There was a problem hiding this comment.
I get this error. Do you see it, too?
It seems like Col doesn't exist in pf5.
Contributor
Author
Uh, true! Amended, thanks :) |
kmalyjur
requested changes
Jun 17, 2026
| error && error.errorMsg ? ( | ||
| <Col sm={12}> | ||
| <Alert type="error"> | ||
| <Alert ouiaId="ansible-roles-switcher-error" type="error"> |
| <Col sm={12}> | ||
| <Alert type="error"> | ||
| <Alert ouiaId="ansible-roles-switcher-error" type="error"> | ||
| <ErrorMsg error={error} /> |
There was a problem hiding this comment.
I think that instead of ErrorMsg, the Alert's title could be used like this:
<Alert variant="danger" title="Danger alert title" ouiaId="DangerAlert" />
Contributor
Author
|
@kmalyjur thank you, I think I've applied all the suggestions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of pf3 to pf5 conversion, supplements #792