Fixes #39317 - Update icons from pf3 to pf5#790
Conversation
Lukshio
left a comment
There was a problem hiding this comment.
Old fa icons has to be replaced by PF5 variants:
There was a problem hiding this comment.
Replace icon props to PF5, typedoes not exists and className is replaced by iconSize
|
I'd leave this one for now as is, it points to the emptystate from foreman, which I guess we'll need to update anyway after theforeman/foreman#10986 gets in |
EmptyState accepts icon component as a prop. So it should be replaced. |
I got rid of the iconType prop, but from what I could find on the foreman side the icon="lock" prop should work ok as EmptyState runs it trough the iconMapper https://github.com/pondrejk/foreman/blob/60bc5fd267080873cb5db30ca227f4c1d713d44f/webpack/assets/javascripts/react_app/components/common/Icon/IconMapper.js#L78 |
Changes looks good. I think that the EmptyState should be backwards compatible after update. Please update the test snapshot. Packit tested. |
Updated, thanks! |
Overview of Changes