Skip to content

Fixes #39486 - deprecate FormField #11078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lukshio wants to merge 1 commit into
base: develop
Choose a base branch
from
+20 −1
Open

Fixes #39486 - deprecate FormField #11078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion webpack/assets/javascripts/react_app/components/common/forms/FormField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React, { useEffect, useState } from 'react';
import PropTypes from 'prop-types';
import classNames from 'classnames';
import {
Expand All @@ -12,11 +12,22 @@ import { Icon } from '@patternfly/react-core';
import { WarningTriangleIcon, ErrorCircleOIcon } from '@patternfly/react-icons';
import InputFactory from './InputFactory';
import { noop } from '../../../common/helpers';
import { deprecate } from '../../../common/DeprecationService';

const InlineMessage = ({ error, warning, helpInline }) => {
if (!error && !warning && !helpInline) {
return null;
}

// eslint-disable-next-line react-hooks/rules-of-hooks
useEffect(() => {
deprecate(
`InlineMessage from common/forms/FormField`,
'Form from @patternfly/react-core',
'5.1'
);
}, []);

return (
<HelpBlock
className={classNames('help-inline', {
Expand Down Expand Up @@ -89,6 +100,14 @@ const FormField = ({
if (innerWarning) validationState = 'warning';
if (innerError) validationState = 'error';

useEffect(() => {
deprecate(
`common/forms/FormField`,
'Form from @patternfly/react-core',
'5.1'
);
}, []);

@pondrejk pondrejk Jul 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels strange to see this twice in the same file, I see it's because FormField.js exports also InlineMessage. I found only one use of InlineMessage in a test snapshot. So I wonder if it would be too much of a hustle to either separate that thing into it's own file or just drop it with the snapshot test, that should be dropped sooner or later anyway

return (
<FormGroup
controlId={id}
Expand Down
Loading