Skip to content

Fixes #39475 - Hide count in SelectAllCheckbox when unavailable#11060

Merged
Lukshio merged 1 commit into
theforeman:developfrom
kmalyjur:selectallcheckbox
Jul 3, 2026
Merged

Fixes #39475 - Hide count in SelectAllCheckbox when unavailable#11060
Lukshio merged 1 commit into
theforeman:developfrom
kmalyjur:selectallcheckbox

Conversation

@kmalyjur

@kmalyjur kmalyjur commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Display 'Select all' instead of 'Select all (0)' when totalCount is null, enabling tables to fetch counts on demand without showing misleading zero values.

Needed for theforeman/foreman_leapp#171.

@kmalyjur kmalyjur force-pushed the selectallcheckbox branch from 632e0da to 2230480 Compare July 1, 2026 08:39
@Lukshio

Lukshio commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@kmalyjur can you please provide more information about how it should work? Normally I see real count on Select All button and no fetch after click.

@Lukshio

Lukshio commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@kmalyjur can you please provide more information about how it should work? Normally I see real count on Select All button and no fetch after click.

Question resolved in parent PR

@Lukshio Lukshio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lukshio Lukshio merged commit e0522f2 into theforeman:develop Jul 3, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants