Refs #39361 - Fix ByIdName lookup when only id part is provided#11055
Merged
Conversation
adamruzicka
force-pushed
the
matchity-match
branch
from
81c05aa to
df6482a
Compare
Contributor
Author
|
theforeman/foreman_puppet#447 seems to be happy about this |
adamruzicka
force-pushed
the
matchity-match
branch
from
df6482a to
5b61934
Compare
Contributor
Author
|
squashed |
Contributor
Author
|
I'll take the ack and run with it Edit: Nope, github won't let me approve my own stuff and merging is gated behind that. |
ekohl
reviewed
Jun 30, 2026
ekohl
left a comment
ekohl
left a comment
Member
There was a problem hiding this comment.
Should this be Refs #39361 instead of its own issue?
Fixes 7beaa06 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
adamruzicka
changed the title
Contributor
Author
|
Re-attached to the previous ruby3.3 issue |
Member
|
Did you forget to push the updated git commit? |
adamruzicka
force-pushed
the
matchity-match
branch
from
5b61934 to
c6f2123
Compare
Contributor
Author
|
/me sighs of course |
ekohl
changed the title
ekohl
approved these changes
Jul 1, 2026
Contributor
Author
|
Now I'll really take the ack and run with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 7beaa06 / #11004