Fixes #38849: update forms/FormField to use pf5#10733
Draft
kfamilonidis wants to merge 1 commit into
Draft
Conversation
kfamilonidis
force-pushed
the
pf5-form-field
branch
3 times, most recently
from
8cba11c to
eeb063a
Compare
kfamilonidis
force-pushed
the
pf5-form-field
branch
3 times, most recently
from
2b1db65 to
9fc3ebc
Compare
kfamilonidis
force-pushed
the
pf5-form-field
branch
from
9fc3ebc to
9935280
Compare
MariaAga
reviewed
Jan 30, 2026
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
it seems that formField is not used outside the definition of the component and could be removed altogether.
Contributor
Author
There was a problem hiding this comment.
pls. double check if that's the case.
Contributor
Author
There was a problem hiding this comment.
I took a different approach and removed the enzyme test from the codebase #11083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wip