Refs #37102 - detect plugins webpack by looking for remoteEntry.js

[evgeni]

Since we switched to Webpack 5, there are no more manifest.json in the plugins webpack folder, but we need some token to detect that we gotta load webpack stuff.

[evgeni]

For devel setups and Debian this works by checking webpack/index.js, but in RPM we exclude this folder from the installed GEM:
https://github.com/theforeman/foreman-packaging/blob/rpm/develop/gem2rpm/foreman_plugin.spec.erb#L30
(it's correct, we don't need the webpack stuff ON the target system, as we don't compile any assets there, but…)

[evgeni]

arguably, webpack_manifest_path.present? can be dropped now
also, this method hits the disk on every page load, we should cache the result in memory (but scope creep!)

[ekohl]

Which is exactly what I aimed at in #9834 (comment) but I should have pushed further on this.

[evgeni]

you mean "hits the disk" part?

[evgeni]

With this applied I get working Katello prod installs with Webpack 5 \o/

[MariaAga]

When is path && (File.file?(File.join(path, 'webpack', 'index.js')) false? I only see it as true all the time

[evgeni]

when we use RPMs as we do not ship the webpack folder at all there, as we do not need to compile anything from it on the system where we deploy.

[MariaAga]

probably should do the - -> _ change for tasks here

[evgeni]

Good catch! Updated

[evgeni]

[test unit]

seems unrelated