Fixes #39447 - Guard dangerous host bulk actions with scope hash

[sbernhard]

This guard uses digests of user ID, location ID, organization ID, and all host IDs a user has access. This digest is passed to the UI and forwarded to 'some' bulk actions like delete, power off which can really 'destroy' a datacenter managed by foreman. In the bulk action the hash is recalculated and only if the hash stays the same, the bulk action is executed. Not perfect, but I think it solves both issues.

[sbernhard]

the Katello test calls bulk_destroy directly with only:
{ :search => "id ^ (...)" }

• bulk_destroy is now guarded by validate_scope_hash!
• without scope_hash or skip_scope_hash, the controller returns:
  • 409
  • "The host scope changed or is missing integrity data..."

The failing test is here: katello/test/controllers/api/v2/hosts_bulk_actions_controller_extensions_test.rb:11

[jeremylenz]

Thanks @sbernhard! I like this idea a lot; just have a question/concern below.

[sbernhard]

Found issues in error toast handling for disassociate bulk action: #11045

[sbernhard]

Currently, the guard is only for the "most critical" bulk actions. It would be pretty easy to extend this for all bulk actions in the hosts controller. Already talked to @nadjaheitmann - she would prefer this. What's your opinion @jeremylenz?

[jeremylenz]

@sbernhard Thanks for doing all the performance testing! I agree that "one-shot pluck" looks like a good compromise of increasing performance while still keeping the readability and maintainability of Ruby code. (Still amazing how fast SQL is, though 😄) I also think one-shot pluck is fast enough (based on your numbers) that extending it to all controller actions should be fine. 👍

[nadjaheitmann]

@sbernhard @jeremylenz The guard does not save us from implementing location parameter evaluation for the host bulk actions controller which is done in the PR that I have opened.

[jeremylenz]

Tested and works well after I made one change.

[sbernhard]

We also need:
#11045
Katello/katello#11790