Skip to content

Fixes #39447 - adapt bulk action delete test#11790

Open
sbernhard wants to merge 1 commit into
Katello:masterfrom
ATIX-AG:fixes_39447
Open

Fixes #39447 - adapt bulk action delete test#11790
sbernhard wants to merge 1 commit into
Katello:masterfrom
ATIX-AG:fixes_39447

Conversation

@sbernhard

@sbernhard sbernhard commented Jun 25, 2026

Copy link
Copy Markdown
Member

Necessary because of:
theforeman/foreman#11038

What are the changes introduced in this pull request?

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Summary by CodeRabbit

  • Tests
    • Updated an automated test to use a clearer parameter format for a bulk delete request.
    • No user-facing behavior changed.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6d6fe1e7-b676-46e6-9ac2-8459b5bbba50

📥 Commits

Reviewing files that changed from the base of the PR and between a992083 and abdfd9b.

📒 Files selected for processing (1)
  • test/controllers/api/v2/hosts_bulk_actions_controller_extensions_test.rb

📝 Walkthrough

Walkthrough

The test request in test_bulk_destroy is reformatted so the params hash spans multiple lines. The :search expression and :skip_scope_hash value remain unchanged.

Changes

Hosts bulk destroy test

Layer / File(s) Summary
Request params formatting
test/controllers/api/v2/hosts_bulk_actions_controller_extensions_test.rb
The delete :bulk_destroy call in test_bulk_destroy uses a multi-line params hash with the same :search and :skip_scope_hash entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the only change: adapting the bulk action delete test.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aidenfine aidenfine left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants