Fixes #39348 - implement executiondetails tab, and combine errors and running steps into it#816

Merged

Lukshio merged 4 commits into

theforeman:masterfrom

andreilakatos:taskdetails-pf5-update-execution-details

Jun 24, 2026

andreilakatos commented May 22, 2026 •

edited

Loading

Contributor

pr-processor Bot added Not yet reviewed Waiting on contributor labels

andreilakatos commented

View reviewed changes

webpack/ForemanTasks/Components/TaskDetails/Components/TaskInfo.js

pr-processor Bot removed the Not yet reviewed label

andreilakatos commented

View reviewed changes

webpack/ForemanTasks/Components/TaskDetails/ExecutionDetails.js

andreilakatos commented

View reviewed changes

webpack/ForemanTasks/Components/TaskDetails/TaskDetails.js

andreilakatos commented

View reviewed changes

webpack/ForemanTasks/Components/TaskDetails/__tests__/ExecutionDetails.test.js

andreilakatos commented

View reviewed changes

webpack/ForemanTasks/Components/TaskDetails/__tests__/TaskDetails.fixtures.js

andreilakatos commented

View reviewed changes

webpack/ForemanTasks/Components/TaskDetails/__tests__/TaskDetails.test.js

This was referenced May 22, 2026

Fixes #39349 - implement new button structure with kebab menu #817

Merged

Fixes #39350 - implement expandable rows for task info #818

Open

Lukshio self-assigned this

Lukshio reviewed

View reviewed changes

webpack/ForemanTasks/Components/TaskDetails/ExecutionDetails.js

Lukshio requested changes

View reviewed changes

webpack/ForemanTasks/Components/TaskDetails/TaskDetails.js Outdated

webpack/ForemanTasks/Components/TaskDetails/TaskDetails.js Outdated

pr-processor Bot added the Needs re-review label

andreilakatos force-pushed the taskdetails-pf5-update-execution-details branch from 75798f1 to fd65d5e Compare

June 18, 2026 11:14

pr-processor Bot removed the Waiting on contributor label

andreilakatos force-pushed the taskdetails-pf5-update-execution-details branch from 287d4ec to 436cd98 Compare

June 18, 2026 14:44


          Fixes #39348 - implement executiondetails tab, and combine errors and…

f18fd94

… running steps into it

andreilakatos force-pushed the taskdetails-pf5-update-execution-details branch from 436cd98 to f18fd94 Compare

June 18, 2026 14:52

Lukshio requested changes

View reviewed changes

webpack/ForemanTasks/Components/TaskDetails/TaskDetails.js

webpack/ForemanTasks/Components/TaskDetails/TaskDetails.js Outdated

webpack/ForemanTasks/Components/TaskDetails/Components/TaskInfo.js Outdated

webpack/ForemanTasks/Components/TaskDetails/TaskDetails.js

webpack/ForemanTasks/Components/TaskDetails/ExecutionDetails.js Outdated

webpack/ForemanTasks/Components/TaskDetails/__tests__/TaskDetails.fixtures.js Outdated

webpack/ForemanTasks/Components/TaskDetails/__tests__/TaskDetails.fixtures.js Outdated

pr-processor Bot added Waiting on contributor and removed Needs re-review labels


          Refs #39348 - remove unused props, improve tests, change text recomme…

f806c11

…ndations

pr-processor Bot added Needs re-review and removed Waiting on contributor labels

Lukshio commented Jun 23, 2026

Contributor

CI failures related


          Refs #39348 - remove not needed check

cfb01af

Lukshio commented Jun 24, 2026

Contributor

This function can be deleted now

foreman-tasks/webpack/ForemanTasks/Components/TaskDetails/TaskDetailsSelectors.js

Line 42 in 351fc98

export const selectErrors = state => {


          Refs #39348 - remove unused selector

a9d7bf0

andreilakatos commented Jun 24, 2026

Contributor Author

This function can be deleted now

foreman-tasks/webpack/ForemanTasks/Components/TaskDetails/TaskDetailsSelectors.js

Line 42 in 351fc98

export const selectErrors = state => {

Done

Lukshio approved these changes

View reviewed changes

Lukshio left a comment

Contributor

lgtm, qe tested

pr-processor Bot removed the Needs re-review label

Lukshio merged commit 16506cc into theforeman:master

17 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet