Fixes #31834: Ensure PostgreSQL 12 is enabled on EL8

[ehelms]

I was not sure if I should try to code up the steps to upgrade Foreman EL8 existing databases or leave that to the docs. The steps are effectively:

# ensure enough disk space on /var/lib/pgsql for twice the size of /var/lib/pgsql/data

systemctl stop postgresql foreman dynflow\*
mv /var/lib/pgsql/data /var/lib/pgsql/data-old
sed -i "s/\/var\/lib\/pgsql\/data/\/var\/lib\/pgsql\/data-old/g" data-old/postgresql.conf

dnf -y module remove postgresql-server
dnf -y module reset postgresql
dnf -y module enable postgresql:12
dnf -y install postgresql-server postgresql-upgrade

sudo -u postgres pg_upgrade --old-bindir /usr/lib64/pgsql/postgresql-10/bin --new-bindir /bin --old-datadir /var/lib/pgsql/data-old/ --new-datadir /var/lib/pgsql/data

[ekohl]

PG 13 is also out and I wouldn't be surprised if someone used it at some point. They may be annoyed that it forces them to downgrade.

Another thing to consider is users who use packages from postgresql.org. https://www.postgresql.org/download/linux/redhat/ suggests it installs as postgresql$VERSION-server (so postgesql12-server). Not sure if they'll show up and if so, how but we have seen community users who use them.

[ehelms]

Hrmm, sounds like you are saying I should just limit this to Katello and leave Foreman alone since it can be in a wide variety of states.

[ekohl]

I recall that user of postgresql.org was running Katello and ran into problems because of the evr package.

[ehelms]

Externally or local?

[ekohl]

https://community.theforeman.org/t/foreman-1-19-test-week/10533/4

[ehelms]

That was quite a bit ago. And I feel like Katello has traditionally supported PG that comes with the OS to reduce support burden and matrix. We did this on EL7 through the use of the SCL as well. I have simplified this PR to just do this for the Katello scenario.

[ekohl]

I really doubt that this will work.

[ehelms]

This now uses the dnfprovider for the package type through Puppet which is available as of 6.15.0 and 5.5.20 per https://tickets.puppetlabs.com/browse/PUP-10235

[ekohl]

I can take a look at if we can solve this in puppetlabs-postgresql as a long term solution.

[ehelms]

Could be nice there long term, I dont see modules going away.

[ekohl]

I started with theforeman/puppet-candlepin#175. We've observed that starting Puppet typically adds a few seconds so I'd prefer to solve it as part of the main loop.

[ehelms]

This blocks Katello so we need to get any changes and release ASAP.

[ekohl]

I've submitted #650 which I believe is a more correct approach. It doesn't deal with upgrades yet, but IMHO it's the right long term implementation.

[ehelms]

#650 doesnt look like it will work for a release branch which we need this change on, so will we merge this change, cherry pick it and then pick up the long term fixes as they get released?

[ekohl]

Summarizing an offline discussion:

• Enable pki-core module on EL8 puppet-candlepin#175 should be turned into a release and included in 2.4
• PostgreSQL 12 is not a blocker for RC1 but is something we want to fix prior to GA so there are no Katello users on PostgreSQL 10.
• For PG 10 users (existing Foreman on EL8) we need to look into a strategy. It is likely we will make this an upgrade note that users need to upgrade prior to upgrading to Foreman 2.4 on EL8.