Skip to content

Hide virt-who deployment on containerized ProjectServer#5034

Open
Lennonka wants to merge 2 commits into
theforeman:masterfrom
Lennonka:update-virt-who-deployment-containerized
Open

Hide virt-who deployment on containerized ProjectServer#5034
Lennonka wants to merge 2 commits into
theforeman:masterfrom
Lennonka:update-virt-who-deployment-containerized

Conversation

@Lennonka

@Lennonka Lennonka commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What changes are you introducing?

Updates for the Configuring virt-who for virtual machine subscriptions guide

  • Enabling containerized build
  • Hiding virt-who deployment on containerized ProjectServer

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

  • Need to see the preview
  • virt-who cannot run on containerized ProjectServer

SAT-45985

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

  • Assisted-by: Claude Code
  • Will be added to upstream navigation later
  • There will be more changes to this guide for containerized before it will be ready

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into: N/A

@github-actions github-actions Bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

The PR preview for 70b7df2 is available at theforeman-foreman-documentation-preview-pr-5034.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

chris1984
chris1984 reviewed Jul 9, 2026
View reviewed changes

@chris1984 chris1984 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, left one comment

Comment thread guides/common/modules/ref_virt-who-configuration-overview.adoc Outdated
@Lennonka Lennonka force-pushed the update-virt-who-deployment-containerized branch from 0d61faf to 5f985b2 Compare July 9, 2026 15:07
@Lennonka Lennonka changed the title Remove virt-who deployment on ProjectServer Hide virt-who deployment on containerized ProjectServer Jul 9, 2026
@Lennonka Lennonka marked this pull request as ready for review July 9, 2026 16:36
@Lennonka Lennonka requested a review from chris1984 July 9, 2026 16:36
chris1984
chris1984 approved these changes Jul 9, 2026
View reviewed changes

@chris1984 chris1984 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for fixing the hypervisor change.

@Lennonka Lennonka added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Jul 9, 2026
@Lennonka

Lennonka commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Removing the Needs testing label because we're just removing stuff in this PR.
We plan functional testing of the docs once all changes will have been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@chris1984 chris1984 chris1984 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Needs style review Requires a review from docs style/grammar perspective tech review done No issues from the technical perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Lennonka @chris1984