Skip to content

Add info about Ansible playbook import#2952

Merged
Lennonka merged 1 commit into
theforeman:masterfrom
Lennonka:improve-playbook-import
Apr 11, 2024
Merged

Add info about Ansible playbook import#2952
Lennonka merged 1 commit into
theforeman:masterfrom
Lennonka:improve-playbook-import

Conversation

@Lennonka

@Lennonka Lennonka commented Apr 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

When I was working on #2951 , I noticed that those modules were missing useful info.
Adding and tested in Satellite 6.15.
The feature has been available since Satellite 6.12 (~ Foreman 3.3).

Please cherry-pick my commits into:

  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (planned Satellite 6.15)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • Foreman 3.4/Katello 4.6 (EL8 only)
  • Foreman 3.3/Katello 4.5 on EL7 & EL8 (Satellite 6.12 on EL8 only; orcharhino 6.4/6.5 on EL8 only)
  • We do not accept PRs for Foreman older than 3.3.

@github-actions

github-actions Bot commented Apr 8, 2024 •
edited
Loading

Copy link
Copy Markdown

The PR preview for 702ba93 is available at theforeman-foreman-documentation-preview-pr-2952.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@Lennonka Lennonka force-pushed the improve-playbook-import branch from 92daf55 to ed6c3cb Compare April 8, 2024 18:46
Lennonka
Lennonka commented Apr 8, 2024
View reviewed changes
Comment thread guides/common/modules/proc_importing-all-available-ansible-playbooks.adoc
maximiliankolb
maximiliankolb reviewed Apr 9, 2024
View reviewed changes

@maximiliankolb maximiliankolb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor suggestions. 👍 for adding the paths!

Comment thread guides/common/modules/proc_importing-all-available-ansible-playbooks.adoc
Comment thread guides/common/modules/proc_importing-an-ansible-playbook-by-name.adoc
apinnick
apinnick reviewed Apr 9, 2024
View reviewed changes
Comment thread guides/common/modules/proc_importing-all-available-ansible-playbooks.adoc Outdated
apinnick
apinnick reviewed Apr 9, 2024
View reviewed changes
Comment thread guides/common/modules/proc_importing-an-ansible-playbook-by-name.adoc Outdated
@Lennonka Lennonka force-pushed the improve-playbook-import branch from ed6c3cb to 702ba93 Compare April 9, 2024 16:17
@Lennonka

Lennonka commented Apr 9, 2024

Copy link
Copy Markdown
Contributor Author

Good to go?

@Lennonka

Lennonka commented Apr 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I'm assuming there are no further comments style wise. And it works for me :)))

@Lennonka Lennonka merged commit 5dad30c into theforeman:master Apr 11, 2024
@Lennonka

Lennonka commented Apr 11, 2024

Copy link
Copy Markdown
Contributor Author

Cherry-picked:

@Lennonka Lennonka deleted the improve-playbook-import branch April 11, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximiliankolb maximiliankolb maximiliankolb left review comments
@apinnick apinnick apinnick left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lennonka @maximiliankolb @apinnick