Resolves SAT-40990 - Modify condition that decides proxy_type to be used#175
Merged
stejskalleos merged 1 commit intoDec 10, 2025
Merged
Conversation
stejskalleos
approved these changes
Dec 10, 2025
stejskalleos
left a comment
stejskalleos
left a comment
Contributor
There was a problem hiding this comment.
LGTM, fix works as expected
Contributor
|
Thanks @jpasqualetto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous condition always returns false, which end up with proxy_type set to proxy all the time, regardless of what was chosen/configured by the user.