Skip to content

Deprecate content_view and lifecycle_environment for activation_key#1982

Merged
evgeni merged 1 commit into
theforeman:developfrom
jeremylenz:deprecate-ak-cv-lce-params
Jul 9, 2026
Merged

Deprecate content_view and lifecycle_environment for activation_key#1982
evgeni merged 1 commit into
theforeman:developfrom
jeremylenz:deprecate-ak-cv-lce-params

Conversation

@jeremylenz

Copy link
Copy Markdown
Contributor

Summary

  • Deprecate the content_view and lifecycle_environment parameters on the activation_key module in favor of content_view_environments
  • On newer Katello versions (where content_view_id/environment_id API params are removed), internally convert the deprecated params to content view environment labels
  • Multi-CV activation keys are protected from accidental overwrite — using deprecated params against a multi-CV AK fails with a clear error
  • Use safe .get() access in the _update_entity workaround to prevent KeyError on newer Katello API responses
  • Backward compatible: old Katello versions work unchanged (conversion is skipped)

Split out from #1977 per review feedback. Host/hostgroup changes will follow separately.

Related Katello PR: Katello/katello#11753

🤖 Generated with Claude Code

On newer Katello versions where the old content_view_id/environment_id
API params have been removed, internally convert to content view
environment labels. Multi-CV activation keys are protected from
accidental overwrite.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@evgeni evgeni merged commit d28aa2f into theforeman:develop Jul 9, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants