Skip to content

Fix JSON formatting issue and typos #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Himess wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix JSON formatting issue and typos #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66c113f
Update GroupNFT.sol
Himess Jan 22, 2025
a42f097
Update IPAccountImpl.sol
Himess Jan 23, 2025
763d153
Update StorageLayoutCheck.s.sol
Himess Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/GroupNFT.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ contract GroupNFT is IGroupNFT, ERC721Upgradeable, AccessManagedUpgradeable, UUP
'"name": "Story Protocol IP Assets Group #',
id.toString(),
'",',
'"description": IPAsset Group",',
'"description": "IPAsset Group",',
'"external_url": "https://protocol.storyprotocol.xyz/ipa/',
id.toString(),
'",',
Expand Down
4 changes: 2 additions & 2 deletions contracts/IPAccountImpl.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ contract IPAccountImpl is ERC6551, IPAccountStorage, IIPAccount {
}
}

/// @dev Updates the IP Account's state all execute transactions.
/// @dev Updates the IP Account's state for all executed transactions.
/// @param to The "target" of the execute transactions.
/// @param value The amount of Ether to send.
/// @param data The data to send along with the transaction.
Expand All @@ -238,7 +238,7 @@ contract IPAccountImpl is ERC6551, IPAccountStorage, IIPAccount {

/// @dev Override Solady 6551 _isValidSigner function.
/// @param signer The signer to check
/// @param extraData The extra data to check against, it should bethe address of the recipient for IPAccount
/// @param extraData The extra data to check against, it should be the address of the recipient for IPAccount
/// @param context The context for validating the signer
/// @return bool is true if the signer is valid, false otherwise
function _isValidSigner(
Expand Down
4 changes: 2 additions & 2 deletions script/foundry/utils/upgrades/StorageLayoutCheck.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ contract StorageLayoutChecker is Script {
uint8 i = 0;
// npx @openzeppelin/upgrades-core validate <build-info-dir> --requireReference
inputBuilder[i++] = "npx";
inputBuilder[i++] = string.concat("@openzeppelin/upgrades-core");
inputBuilder[i++] = "@openzeppelin/upgrades-core";
inputBuilder[i++] = "validate";
inputBuilder[i++] = string.concat(outDir, "/build-info");

Expand All @@ -62,4 +62,4 @@ contract StorageLayoutChecker is Script {

return inputs;
}
}
}