CTA Section for landing page#2
Open
agarciacif wants to merge 25 commits into
Open
Conversation
Renamed App to CTA for CTA component.
It was agreed to follow this project structure convention for React components. Now react components go in src/components/componentName/componentName.jsx Also assets now go outside src, in root directory.
After the code review, it was decided to style everything on it's own style.css and leave index.css untouched
This will minimize the number of conflicts between master branch and my branch.
Removed my component from main.jsx to fulfill rule 5 of code review "Do not insert your component into the main react Render".
Final touches to minimizing conflicts between my branch and main branch
Collaborator
Author
Review with @skyc4ff3ine - removed root style from CTA style - removed display flex from body -> added new container to center elements. - removed redundant styles like border-box, flex-direction:row and padding: 0 margin: 0
Svg in public/
Hero Page Design
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done the CTA section task.
Result:
Measures for all elements taken from Figma design