refactor(config): split config.go and rename fields to camelCase#157
Open
Gautam7352 wants to merge 1 commit into
Open
refactor(config): split config.go and rename fields to camelCase#157Gautam7352 wants to merge 1 commit into
Gautam7352 wants to merge 1 commit into
Conversation
Gautam7352
commented
Apr 17, 2026
Gautam7352
commented
Contributor
- Extract postgresPortFromEnv, loadEnvFile, findEnvFile into loader.go
- Extract validateDatabaseConfig into validation.go
- Rename AppConfig fields from SCREAMING_SNAKE to camelCase (PostgresHost etc.)
- Skip .env loading in production (APP_ENV=production)
- Harden JWT_SECRET: fatal in production, warn with safe default in dev
- Update database/db.go to use renamed AppConfig fields
- Extract postgresPortFromEnv, loadEnvFile, findEnvFile into loader.go - Extract validateDatabaseConfig into validation.go - Rename AppConfig fields from SCREAMING_SNAKE to camelCase (PostgresHost etc.) - Skip .env loading in production (APP_ENV=production) - Harden JWT_SECRET: fatal in production, warn with safe default in dev - Update database/db.go to use renamed AppConfig fields
TanishqSingla
requested changes
Apr 18, 2026
Comment on lines
+9
to
+12
| PostgresPassword string | ||
| PostgresUser string | ||
| PostgresDB string | ||
| PostgresHost string |
Contributor
There was a problem hiding this comment.
Is camel case related to some go conventions? Usually constants are defined as snake case capital letters
| "github.com/joho/godotenv" | ||
| ) | ||
|
|
||
| func loadEnvFile() { |
Contributor
There was a problem hiding this comment.
We should not be using files for environment variable? Why is this function present?
| return "", os.ErrNotExist | ||
| } | ||
|
|
||
| func postgresPortFromEnv() (int, error) { |
Contributor
There was a problem hiding this comment.
Did not get the point of this function. Why do we need a function to get port of postgres?
| func validateDatabaseConfig(cfg AppConfig) error { | ||
| missing := make([]string, 0, 4) | ||
|
|
||
| if cfg.PostgresUser == "" { |
Contributor
There was a problem hiding this comment.
Are if statements the only thing we can do?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.