Skip to content

Fix Rockchip I2C pinctrl group #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bestquark merged 1 commit into from
Aug 12, 2026
+9 −5
Merged

Fix Rockchip I2C pinctrl group #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions device/overlays/cdmx-zero3w-i2c-gpio.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,13 @@
fragment@2 {
target = <&pinctrl>;
__overlay__ {
cdmx_i2c_gpio_pins: cdmx-i2c-gpio-pins {
/* bank 0, RK_PD1/RK_PD0 (25/24), GPIO function */
rockchip,pins =
<0 25 0 &pcfg_pull_up>,
<0 24 0 &pcfg_pull_up>;
cdmx-i2c-gpio {
cdmx_i2c_gpio_pins: cdmx-i2c-gpio-pins {
/* bank 0, RK_PD1/RK_PD0 (25/24), GPIO function */
rockchip,pins =
<0 25 0 &pcfg_pull_up>,
<0 24 0 &pcfg_pull_up>;
};
};
};
};
Expand Down
2 changes: 2 additions & 0 deletions tests/host/imager_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,8 @@ assert_eq 1 "$(grep -c '^legacy_i2c=/boot/dtbo/rk3568-i2c4-m0.dtbo$' "$ROOT/devi
'legacy I2C4 mapping is explicitly disabled'
assert_eq 1 "$(grep -c 'i2c-gpio-cdmx {' "$ROOT/device/overlays/cdmx-zero3w-i2c-gpio.dts")" \
'software I2C adapter has a stable discoverable name'
assert_eq 1 "$(grep -c '^[[:space:]]*cdmx-i2c-gpio {$' "$ROOT/device/overlays/cdmx-zero3w-i2c-gpio.dts")" \
'Rockchip pinctrl pins are nested inside a function group'
assert_eq 1 "$(grep -c 'sda-gpios = <&gpio0 24 6>;' "$ROOT/device/overlays/cdmx-zero3w-i2c-gpio.dts")" \
'physical pin 10 is open-drain GPIO0_D0 SDA'
assert_eq 1 "$(grep -c 'scl-gpios = <&gpio0 25 6>;' "$ROOT/device/overlays/cdmx-zero3w-i2c-gpio.dts")" \
Expand Down
Loading