Pantalaimon Damnatio Memoriae Stage 1#679
Open
FSG-Cat wants to merge 4 commits into
Open
Conversation
Gnuxie
reviewed
Jan 17, 2025
Co-authored-by: Gnuxie <50846879+Gnuxie@users.noreply.github.com>
Member
|
We need verify what happens when we use a password with pantalimon and where does that password go, before making a new option option to pass a password secret without understanding what the behavior is. i guess write down the steps for what happens with the password, what methods are called and if it is persisted anywhere, then add that to the PR. like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.