Skip to content

Bump default timeout to 600s and raise max to 1800s #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
that-github-user merged 1 commit into from
Mar 28, 2026
Merged

Bump default timeout to 600s and raise max to 1800s #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ program
}

const timeout = parseInt(opts.timeout, 10);
if (Number.isNaN(timeout) || timeout < 10 || timeout > 600) {
console.error("Error: --timeout must be a number between 10 and 600 seconds");
if (Number.isNaN(timeout) || timeout < 10 || timeout > 1800) {
console.error("Error: --timeout must be a number between 10 and 1800 seconds");
process.exit(1);
}

Expand Down
6 changes: 3 additions & 3 deletions src/utils/config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe("config", () => {
it("has expected default values", () => {
assert.equal(BUILT_IN_DEFAULTS.attempts, 3);
assert.equal(BUILT_IN_DEFAULTS.model, "sonnet");
assert.equal(BUILT_IN_DEFAULTS.timeout, 300);
assert.equal(BUILT_IN_DEFAULTS.timeout, 600);
assert.equal(BUILT_IN_DEFAULTS.runner, "claude-code");
assert.equal(BUILT_IN_DEFAULTS.threshold, 0.3);
assert.equal(BUILT_IN_DEFAULTS.testTimeout, 120);
Expand Down Expand Up @@ -103,7 +103,7 @@ describe("config", () => {
const result = loadConfig();
assert.equal(result.attempts, 7);
assert.equal(result.model, "sonnet");
assert.equal(result.timeout, 300);
assert.equal(result.timeout, 600);
});
});

Expand Down Expand Up @@ -151,7 +151,7 @@ describe("config", () => {
it("returns error for out-of-range timeout", () => {
const error = setConfigValue("timeout", "5");
assert.ok(error);
assert.match(error, /timeout must be an integer between 10 and 600/);
assert.match(error, /timeout must be an integer between 10 and 1800/);
});

it("returns error for out-of-range threshold", () => {
Expand Down
6 changes: 3 additions & 3 deletions src/utils/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export interface Config {
export const BUILT_IN_DEFAULTS: Config = {
attempts: 3,
model: "sonnet",
timeout: 300,
timeout: 600,
runner: "claude-code",
threshold: 0.3,
testTimeout: 120,
Expand Down Expand Up @@ -49,8 +49,8 @@ function validateConfig(partial: Partial<Config>): string | null {
}
}
if (partial.timeout !== undefined) {
if (!Number.isInteger(partial.timeout) || partial.timeout < 10 || partial.timeout > 600) {
return "timeout must be an integer between 10 and 600";
if (!Number.isInteger(partial.timeout) || partial.timeout < 10 || partial.timeout > 1800) {
return "timeout must be an integer between 10 and 1800";
}
}
if (partial.testTimeout !== undefined) {
Expand Down
Loading