Skip to content

indexheader: replace fixed sleep with require.Eventually in reader pool idle test #8978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nikolauspschuetz wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Draft

indexheader: replace fixed sleep with require.Eventually in reader pool idle test #8978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/block/indexheader/reader_pool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,11 @@ func TestReaderPool_ShouldCloseIdleLazyReaders(t *testing.T) {
testutil.Equals(t, float64(1), promtestutil.ToFloat64(metrics.lazyReader.loadCount))
testutil.Equals(t, float64(0), promtestutil.ToFloat64(metrics.lazyReader.unloadCount))

// Wait enough time before checking it.
time.Sleep(idleTimeout * 2)
// Wait until the pool's background reaper (which runs every idleTimeout/10)
// has closed the idle reader, rather than sleeping for a fixed duration.
require.Eventually(t, func() bool {
return promtestutil.ToFloat64(metrics.lazyReader.unloadCount) == 1
}, 5*idleTimeout, idleTimeout/20)

// We expect the reader has been closed, but not released from the pool.
testutil.Assert(t, pool.isTracking(r.(*LazyBinaryReader)))
Expand Down
Loading