execution: expose telemetry for noop operators - #723
Merged
fpetkovski merged 2 commits intoJul 29, 2026
Conversation
pedro-stanaka
force-pushed
the
pedro-stanaka/fix-noop-analysis
branch
from
July 28, 2026 15:08
859cf26 to
62c7178
Compare
pedro-stanaka
marked this pull request as ready for review
July 28, 2026 15:15
fpetkovski
approved these changes
Jul 28, 2026
pedro-stanaka
force-pushed
the
pedro-stanaka/fix-noop-analysis
branch
from
July 28, 2026 16:19
62c7178 to
ac652bd
Compare
Contributor
Author
|
lol, github ci workers are lazy it seems. tests + lint is passing locally |
fpetkovski
reviewed
Jul 29, 2026
noop Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
Co-authored-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Pedro Tanaka <me@pedrotanaka.com.br> Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
pedro-stanaka
force-pushed
the
pedro-stanaka/fix-noop-analysis
branch
from
July 29, 2026 07:24
1bb4ee7 to
66308c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wrap the Noop physical operator with operator telemetry and add a small test to cover the case.
Why
DistributedExecutionOptimizercan validly produce aNoopplan when no remote engine overlaps a query.