Seek to mint in matrix selector to skip decoding unnecessary samples - #722
Draft
chriscerie wants to merge 3 commits into
Draft
Seek to mint in matrix selector to skip decoding unnecessary samples#722chriscerie wants to merge 3 commits into
chriscerie wants to merge 3 commits into
Conversation
chriscerie
force-pushed
the
selector-seek
branch
from
July 22, 2026 23:14
b16987b to
96b654b
Compare
Signed-off-by: Christopher Chang <chriscee@amazon.com>
chriscerie
force-pushed
the
selector-seek
branch
from
July 22, 2026 23:19
96b654b to
922f787
Compare
chriscerie
marked this pull request as draft
July 23, 2026 01:19
Signed-off-by: Christopher Chang <chriscee@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
step > selectRange, consecutive evaluation windows have a gap between them. The matrix scanner currently walks forward through every sample in that gap, decoding each one only to discard the samples between windows.The optimization is to seek the iterator directly to
mintso whole chunks contained in the gap don't get decoded