Potential fix for code scanning alert no. 92: Information exposure through an exception - #180
Merged
Conversation
…rough an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
|
👋 Hello! Thanks for your contribution. We will review this and get back to you as soon as possible. — th30d4y |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/th30d4y/OpenLearnX/security/code-scanning/92
To fix this without changing functionality, keep the 500 behavior and success schema but replace user-facing exception details with a generic message. Log the detailed exception only on the server.
Best change in
backend/routes/quizzes.py:generate_ai_quiz()exceptblock, replace:return jsonify({"success": False, "error": str(e)}), 500with:
return jsonify({"success": False, "error": "An internal error has occurred."}), 500generate_ai_questions()to avoid the same issue there.print(...)logging as-is (it preserves diagnostics server-side).No new imports or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.