Fixed your bugs/limitations#5
Open
treibholz wants to merge 42 commits into
Open
Conversation
Owner
|
Hi, thanks for the pull request, but in its current form, I'm not wlling to merge this, there are a few things that need to be cleaned up before I can review it properly (as well as some comments on the bits I did see):
|
Author
|
Hi, I'm sorry, you cannot use my changes. Maybe I'll find the time to regroup the changes, but don't wait for it. About indentation and the hashbangs: They were not consistent in your code, so I thought you don't care for it and I made them consistent. Anyway: I don't have any problems, if you reject the pull request. Thanks again for your work. Klaus |
Fixed typo with urgency in changelog
- Fixed issue in src/helper that was preventing booting in ubuntu 15.10 (change untested on other systems) - Expanded README.md instructions so slightly less technical users can quickly deploy the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I was very glad to find your project, so I didn't have to start from scratch, you already did most of the work!
I fixed the limitations/bugs you mentioned.
Cheers
Klaus