Skip to content

Fixed your bugs/limitations#5

Open
treibholz wants to merge 42 commits into
tfheen:masterfrom
treibholz:master
Open

Fixed your bugs/limitations#5
treibholz wants to merge 42 commits into
tfheen:masterfrom
treibholz:master

Conversation

@treibholz

Copy link
Copy Markdown

Hi!

I was very glad to find your project, so I didn't have to start from scratch, you already did most of the work!

I fixed the limitations/bugs you mentioned.

Cheers
Klaus

@tfheen

tfheen commented Dec 1, 2013

Copy link
Copy Markdown
Owner

Hi,

thanks for the pull request, but in its current form, I'm not wlling to merge this, there are a few things that need to be cleaned up before I can review it properly (as well as some comments on the bits I did see):

  • Group your changes into logical changes. I'd rather not have something changing something a bit, then a bit more in a different direction.
  • Don't change indentation and the hashbangs. "#! /bin/sh" is completely valid and I prefer it for aestethic reasons.

@treibholz

Copy link
Copy Markdown
Author

Hi,

I'm sorry, you cannot use my changes. Maybe I'll find the time to regroup the changes, but don't wait for it.

About indentation and the hashbangs: They were not consistent in your code, so I thought you don't care for it and I made them consistent.

Anyway: I don't have any problems, if you reject the pull request. Thanks again for your work.

Klaus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants