feat: SW-2053 add collapsible nav rail (navRailHidden) to Data App Shell#137
Open
GracePan-Tetra wants to merge 2 commits into
Open
feat: SW-2053 add collapsible nav rail (navRailHidden) to Data App Shell#137GracePan-Tetra wants to merge 2 commits into
GracePan-Tetra wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
GracePan-Tetra
changed the title
Replace the demo breadcrumb trail with generic placeholder labels (All Projects / Project Name / worksession name). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a `navRailHidden` prop to DataAppShell. When true, the desktop icon nav rail is not rendered, so collapsing the sidebar panel can hide both the rail and the panel, giving the content full width. Wired in the Default story to the panel's collapsed state, with a play-test asserting the rail is hidden when collapsed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
GracePan-Tetra
force-pushed
the
feat/dataappshell-breadcrumb-text
branch
from
ca66967 to
dac22ff
Compare
GracePan-Tetra
force-pushed
the
feat/dataappshell-collapsible-rail
branch
from
15afa45 to
20f19ab
Compare
owilliams-tetrascience
requested changes
Jun 17, 2026
owilliams-tetrascience
left a comment
owilliams-tetrascience
left a comment
Collaborator
There was a problem hiding this comment.
Functionally this works and it's backward-compatible 👍 — one naming change before merge.
Rename navRailHidden → showNavRail (default true).
Everywhere else in the kit, visibility toggles are written in the positive: showLegend, showCloseButton, showLineNumbers, etc. There's no *Hidden prop anywhere, so this one stands out.
It also reads cleaner at the call site — showNavRail={!collapsed} ("show the rail when not collapsed") instead of the double-negative navRailHidden={collapsed} / navRailHidden = false.
/** Show the desktop icon nav rail. Set false to reclaim width when the panel is collapsed. */
showNavRail?: boolean; // default true{showNavRail && <IconRailSidebar {...sidebarProps} />}Since the prop is brand-new and unreleased, the rename is free now and would be a breaking change later. Behavior stays identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
navRailHidden?: booleanprop toDataAppShell. When true, the desktop icon nav rail is not rendered.This lets a consumer collapse the sidebar so that both the workflow panel and the app nav rail hide, giving the content area full width — instead of leaving the rail behind.
API
Default
false— fully backward compatible.Scope
DataAppShell.tsx: new prop + render guard onIconRailSidebar.DataAppShell.stories.tsx: wire to the Default story's collapsed state + play-test asserting the rail is hidden when collapsed.Behavior
Checks
yarn lint✅yarn typecheck✅🤖 Generated with Claude Code